Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for act #111

Merged
merged 7 commits into from Nov 19, 2021
Merged

Test for act #111

merged 7 commits into from Nov 19, 2021

Conversation

domenkozar
Copy link
Member

No description provided.

@catthehacker
Copy link
Contributor

mhm, this will also fail since GHA runners don't have enough space for that image (full-20.04 is +40GB)

@domenkozar
Copy link
Member Author

domenkozar commented Nov 17, 2021 via email

@catthehacker
Copy link
Contributor

well, there you go, (act) works :)

@domenkozar
Copy link
Member Author

thanks a lot @catthehacker

domenkozar and others added 6 commits November 17, 2021 20:29
Co-authored-by: Ryan <me@hackerc.at>
Co-authored-by: Ryan <me@hackerc.at>
Co-authored-by: Ryan <me@hackerc.at>
Co-authored-by: Ryan <me@hackerc.at>
Co-authored-by: Ryan <me@hackerc.at>
@domenkozar
Copy link
Member Author

@catthehacker does act respect GITHUB_ENV? It doesn't seem to be setting $PATH

@catthehacker
Copy link
Contributor

It does and $NIX_PATH seems to be in $GITHUB_ENV but it's not present at any stage in environment

~/install-nix-action act ❯ docker exec -ti act-install-nix-action-test-simple-build-1 /bin/bash
root@alpine-vm:/home/cat/install-nix-action# cat /var/run/act/workflow/envs.txt
NIX_PATH=nixpkgs=channel:nixos-20.03

@catthehacker
Copy link
Contributor

catthehacker commented Nov 19, 2021

At what point NIX_PATH is added to $GITHUB_ENV ? Forgot I can check GitHub Actions run

@catthehacker
Copy link
Contributor

oh well, that 2nd = messes up everything
that's a bug in act

@catthehacker
Copy link
Contributor

@domenkozar should be working fine now

- uses: actions/setup-go@v2.1.4
with:
go-version: '^1.16'
- run: go install github.com/nektos/act@master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use @latest here to not get caught off guard by bugs in master. needed for the bug fix

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@catthehacker a bugfix release would be amazing :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's not up to me to decide, I only review and fix stuff
I have few small fixes that I would really like to push into next release and then I'll ping cplee to get new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants