Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let WithoutPadding returns a new entry #7

Merged
merged 1 commit into from Dec 14, 2022

Conversation

nervo
Copy link
Contributor

@nervo nervo commented Dec 9, 2022

nervo referenced this pull request in nervo/caarlos0-log Dec 9, 2022
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Base: 87.38% // Head: 87.55% // Increases project coverage by +0.17% 🎉

Coverage data is based on head (c0b4f6a) compared to base (20f9258).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   87.38%   87.55%   +0.17%     
==========================================
  Files           5        5              
  Lines         214      217       +3     
==========================================
+ Hits          187      190       +3     
  Misses         26       26              
  Partials        1        1              
Impacted Files Coverage Δ
logger.go 91.89% <ø> (ø)
pkg.go 87.50% <ø> (ø)
entry.go 85.33% <100.00%> (+0.61%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nervo
Copy link
Contributor Author

nervo commented Dec 9, 2022

Issue with govulncheck, but i can't relaunch related github action...

@caarlos0 caarlos0 merged commit 6754d38 into caarlos0:main Dec 14, 2022
@caarlos0
Copy link
Owner

thanks!!

@caarlos0 caarlos0 added the enhancement New feature or request label Dec 14, 2022
@nervo nervo deleted the without-padding-returns-new-entry branch December 14, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants