fix: RequiredIfNoDef with nested structs #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caarlos0
requested changes
Jul 12, 2022
Codecov Report
@@ Coverage Diff @@
## main #229 +/- ##
=======================================
Coverage 98.84% 98.84%
=======================================
Files 2 2
Lines 345 345
=======================================
Hits 341 341
Misses 4 4
Continue to review full report at Codecov.
|
caarlos0
changed the title
|
closes #228 |
Should be done :) |
caarlos0
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix summary
I think, we simply need to check not if the
key(which isprefix + key) is empty, but if thekeyitself. For this, I introduced variableownKey. All other usages ofkeyremained the same. All tests have passed and I added my own test to cover this bug.