refactor: remove unnecessary line #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `nil` check line removed from the `newParserError`function. Because it is called from other functions after checking the `err` whether its value is `nil`. That's why no need to check it again inside the function. * This change will also increase the code coverage from 98.2% to 98.7% with Go's code coverage metrics. Signed-off-by: Gökhan Özeloğlu <gozeloglu@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #212 +/- ##
==========================================
+ Coverage 97.97% 98.83% +0.85%
==========================================
Files 2 2
Lines 346 343 -3
==========================================
Hits 339 339
+ Misses 6 4 -2
+ Partials 1 0 -1
Continue to review full report at Codecov.
|
|
good catch! thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nilcheck line removed from thenewParserErrorfunction. Because it is called from other functions after checking theerrwhether its value isnil. That's why no need to check it again inside the function.This change will also increase the code coverage from 98.2% to 98.7% with Go's code coverage metrics.
This line is one of the two uncovered lines wrt codecov.
Signed-off-by: Gökhan Özeloğlu gozeloglu@gmail.com