Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error in embedded struct when using option RequiredIfNoDef:true #191

Merged
merged 1 commit into from Sep 6, 2021

Conversation

bhallionOhbibi
Copy link
Contributor

This PR follows my previous one and fix an issue I spoted when using the option with embedded structs.

Changes

  • Fix issue causing parse to fail on embedded struct when using RequiredIfNoDef option.
  • Updated test related to RequiredIfNoDef option.

@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #191 (852156b) into master (a670257) will increase coverage by 0.90%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
+ Coverage   98.18%   99.09%   +0.90%     
==========================================
  Files           2        2              
  Lines         331      331              
==========================================
+ Hits          325      328       +3     
+ Misses          4        2       -2     
+ Partials        2        1       -1     
Impacted Files Coverage Δ
env.go 99.07% <100.00%> (+0.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a670257...852156b. Read the comment docs.

@caarlos0 caarlos0 merged commit ba5c1ad into caarlos0:master Sep 6, 2021
@caarlos0
Copy link
Owner

caarlos0 commented Sep 6, 2021

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants