Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: onset hook #185

Merged
merged 4 commits into from Aug 30, 2021
Merged

feat: onset hook #185

merged 4 commits into from Aug 30, 2021

Conversation

caarlos0
Copy link
Owner

@caarlos0 caarlos0 commented Jul 8, 2021

closes #184

@caarlos0
feat: onset hook
6de2096 
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 mentioned this pull request Jul 8, 2021
Closed
@codecov
Copy link

codecov bot commented Jul 8, 2021 •
edited

Codecov Report

Merging #185 (8d3a039) into master (ed139cd) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 8d3a039 differs from pull request most recent head e1996f6. Consider uploading reports for the commit e1996f6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   98.14%   98.19%   +0.05%     
==========================================
  Files           2        2              
  Lines         323      333      +10     
==========================================
+ Hits          317      327      +10     
  Misses          4        4              
  Partials        2        2
Impacted Files Coverage Δ
env.go 98.15% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed139cd...e1996f6. Read the comment docs.

@caarlos0
fix: lint
a672706 
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@caarlos0
Copy link
Owner Author

ping @nicolasdscp

@caarlos0 caarlos0 merged commit 1cd374b into master Aug 30, 2021
@caarlos0 caarlos0 deleted the onset branch August 30, 2021 13:12
nexoscp added a commit to nexoscp/env that referenced this pull request Apr 7, 2022
@nexoscp
feat: onset hook (caarlos0#185)
222531b 
* feat: onset hook

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>

* fix: lint

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Debug message when relying on default values
1 participant
@caarlos0