Enhance missing VCS command detection (errno 13) #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This addresses the bug originally found and documented in the upstream repo: |
ekohl
requested changes
Jun 21, 2019
ekohl
approved these changes
Jun 25, 2019
If a given VCS command is not executable or blocked from execution by a LSM (SELinux/AppArmor) for example, then consider that VCS to be unavailable. This change prevents the error: OSError: [Error 13] Permission denied
- Swap hard-coded error numbers with constants from the errno module.
c4urself
force-pushed
the
fix-vcs-handle-errno13
branch
from
1ee3b14
to
10dd277
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some Linux platforms (possibly due to an LSM such as SELinux or AppArmor) instead of just getting error 2 (File not found) the OS returns error 13 (Permission Denied). This patch treats errorno 2 and 13 the same. Simply put, the VCS is not available and therefore should not be considered.
Without this fix, on some Linux machines, running
bumpversionorbumpversion --helpresults in: