Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate current_version and new_version to commit #70

Merged
merged 4 commits into from Aug 25, 2019
Merged

Propagate current_version and new_version to commit #70

merged 4 commits into from Aug 25, 2019

Conversation

mauvilsa
Copy link
Contributor

Propagate current_version and new_version to commit as environment variables so that pre-commit hooks can distinguish between normal commits and bumpversion commits.

bumpversion/vcs.py Outdated Show resolved Hide resolved
@mauvilsa
Copy link
Contributor Author

mauvilsa commented Jun 8, 2019

@ekohl do you have rights for bump2version in AppVeyor? I have been trying to figure out why the tests fail. The strangest thing is that for my bump2version fork I reran the tests for the latest commit in this repo (Jan 10, 2019), and surprisingly even though they were successful in this repo they were unsuccessful in my fork.

I started a discussion with AppVeyor support (https://help.appveyor.com/discussions/problems/23659-python-tests-successful-in-jan2019-but-same-code-and-tests-fail-may2019). They ask if someone could trigger a rerun of the tests for the latest commit of this repo. Could you please do this? I tried contacting @c4urself but has been a while and haven't received any response.

@c4urself
Copy link
Owner

@mauvilsa -- i've run a rebuild but i've rebuilt some of my other commits as well and I think there's a deeper issue with tox/PYTHONPATH

@mauvilsa
Copy link
Contributor Author

mauvilsa commented Jul 6, 2019

@c4urself I understand that with #73 the AppVeyor problem is solved. But some time has passed and that pull request hasn't been merged. Also it has been many months since there hasn't been a new release of bump2version that is made available in pypi. Is it likely that any time soon this pull request be merged and a released that includes it be available in pypi?

@mauvilsa
Copy link
Contributor Author

mauvilsa commented Aug 1, 2019

@ekohl do you think this pull request has a chance to be approved and be included in the next release of bump2version?

@c4urself
Copy link
Owner

@mauvilsa yep, please rebase, I'll try to get this in next release.

mauvilsa and others added 4 commits August 24, 2019 17:42
…riables so that pre-commit hooks can distinguish between normal commits and bumpversion commits.
- Added feature to README.md so that it is properly documented.
@c4urself c4urself merged commit 464802f into c4urself:master Aug 25, 2019
@florisla florisla added this to the v1.0.0 milestone Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants