Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior if used with --current-version and --new-version #140

Closed
4hopp opened this issue May 6, 2020 · 1 comment
Closed

Behavior if used with --current-version and --new-version #140

4hopp opened this issue May 6, 2020 · 1 comment

Comments

@4hopp
Copy link

4hopp commented May 6, 2020

If bump2version is used with both --current-version and --new-version (or only --new-version, but the current version can be retrieved from the config file) it seems like the part argument is not used at all, though it is required. Is this assumption correct?

Example:

bump2version --current-version 2.0.0 --new-version 2.1.0 major

(My assumption is, that this would result in a minor bump, going from 2.0.0 to 2.1.0 and ignoring the argument major.)

If the part argument is used by bump2version in those cases in any way, then it should be clarified how part affects the result.

If it is not used, then the user should have the option to omit part. If they decide to use part however, then bump2version should check for consistency. (E.g. Is this really a major/minor/patch bump?)

@florisla
Copy link
Collaborator

You're right, part is not used at all, even though it is a required argument.

In many cases you can use a-non-existing-part as the part argument, and it will work just as well.

Issue #22 is tracking this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants