New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support new lines #14
Conversation
This would be possible with the current version, the problem lies on the This change proposes replacing \\n with \n for each serialize option. This makes it so we can now do multi-line serialization while still supporting the serialize functionality. If there's a better way to un-escape, let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would benefit from a test. Would you be able to write one? If needed we can help.
Hey @ekohl , let me know if that's enough! Thanks for the quick reply, we're looking to use this project at work once this is a feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do wonder why Travis isn't running. @c4urself any idea?
Nope, need to check that out. Real busy at work wrapping up Q2 ATM though...
…On Tue, 20 Mar 2018 at 17:25, Ewoud Kohl van Wijngaarden < ***@***.***> wrote:
***@***.**** approved this pull request.
I do wonder why Travis isn't running. @c4urself
<https://github.com/c4urself> any idea?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAX3dj_MM9C8N3vxeeF0TwvdgMHMAHqXks5tgZ4JgaJpZM4Sw7jm>
.
|
@c4urself I can try and setup the travis if you want? |
@sharksforarms that'd be great, go for it |
https://travis-ci.org/sharksforarms/bump2version/builds/358647950 Ok yeah, I think we have to do a bit of work fixing these test cases, I'll take a look |
See #15 https://travis-ci.org/sharksforarms/bump2version/builds/358662223 |
Hey! Any updates? I'd like to start using this package, but this is what's blocking me at the moment. |
Fixes #13