Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support new lines #14

Merged
merged 2 commits into from Apr 19, 2018
Merged

support new lines #14

merged 2 commits into from Apr 19, 2018

Conversation

sharksforarms
Copy link

@sharksforarms sharksforarms commented Mar 19, 2018

Fixes #13

@sharksforarms
Copy link
Author

sharksforarms commented Mar 19, 2018

This would be possible with the current version, the problem lies on the serialize = parameter as it can accept multiple options (each option on a new line). This prevents having multi-line serialization.

This change proposes replacing \\n with \n for each serialize option. This makes it so we can now do multi-line serialization while still supporting the serialize functionality.

If there's a better way to un-escape, let me know.

Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would benefit from a test. Would you be able to write one? If needed we can help.

@sharksforarms
Copy link
Author

Hey @ekohl , let me know if that's enough! Thanks for the quick reply, we're looking to use this project at work once this is a feature.

Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do wonder why Travis isn't running. @c4urself any idea?

@c4urself
Copy link
Owner

c4urself commented Mar 21, 2018 via email

@sharksforarms
Copy link
Author

@c4urself @ekohl Is travis needed to merge and release?

@sharksforarms
Copy link
Author

@c4urself I can try and setup the travis if you want?

@c4urself
Copy link
Owner

@sharksforarms that'd be great, go for it

@sharksforarms
Copy link
Author

https://travis-ci.org/sharksforarms/bump2version/builds/358647950

Ok yeah, I think we have to do a bit of work fixing these test cases, I'll take a look

@sharksforarms
Copy link
Author

sharksforarms commented Mar 26, 2018

See #15
First time using travis, was as simple as logging in using github and activating the repo! Not bad! 👍

https://travis-ci.org/sharksforarms/bump2version/builds/358662223

@sharksforarms
Copy link
Author

Hey! Any updates? I'd like to start using this package, but this is what's blocking me at the moment.

@c4urself c4urself merged commit 287c71e into c4urself:master Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants