We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I think I noticed the error:
c3_chart_internal_fn.parseDate = function (date) { var $$ = this, parsedDate; if (date instanceof Date) { parsedDate = date; } else if (typeof date === 'number' && !isNaN(date)) {// fixed wrong validation parsedDate = new Date(+date); } else { parsedDate = . d a t a T i m e F o r m a t ( .config.data_xFormat).parse(date); } if (!parsedDate || isNaN(+parsedDate)) { window.console.error("Failed to parse x '" + date + "' to Date object"); } return parsedDate; };
The issue was on the validation if (typeof date === 'number' || !isNaN(date))
it should be if (typeof date === 'number' && !isNaN(date))
The text was updated successfully, but these errors were encountered:
Merge pull request #1121 from lbortoli/master
bfdf7de
Fix for issue #1054
fix commited
Sorry, something went wrong.
No branches or pull requests
I think I noticed the error:
c3_chart_internal_fn.parseDate = function (date) { .config.data_xFormat).parse(date);
var $$ = this, parsedDate;
if (date instanceof Date) {
parsedDate = date;
} else if (typeof date === 'number' && !isNaN(date)) {// fixed wrong validation
parsedDate = new Date(+date);
} else {
parsedDate =
}
if (!parsedDate || isNaN(+parsedDate)) {
window.console.error("Failed to parse x '" + date + "' to Date object");
}
return parsedDate;
};
The issue was on the validation
if (typeof date === 'number' || !isNaN(date))
it should be
if (typeof date === 'number' && !isNaN(date))
The text was updated successfully, but these errors were encountered: