From e8c418c406ccca4784e0884e4ceac9b5a65411c7 Mon Sep 17 00:00:00 2001
From: Stefan CORDES <50696194+ca-stefan-cordes@users.noreply.github.com>
Date: Tue, 3 May 2022 19:06:03 +0200
Subject: [PATCH] simplify keepCommentsInPom boolean. #270
---
.../codehaus/mojo/flatten/FlattenMojo.java | 21 ++-----------------
1 file changed, 2 insertions(+), 19 deletions(-)
diff --git a/src/main/java/org/codehaus/mojo/flatten/FlattenMojo.java b/src/main/java/org/codehaus/mojo/flatten/FlattenMojo.java
index 438198fe..4b9907e2 100644
--- a/src/main/java/org/codehaus/mojo/flatten/FlattenMojo.java
+++ b/src/main/java/org/codehaus/mojo/flatten/FlattenMojo.java
@@ -375,7 +375,7 @@ public class FlattenMojo
* @since 1.2.8
*/
@Parameter( property = "flatten.dependency.keepComments", required = false , defaultValue = "false")
- private Boolean keepCommentsInPom;
+ private boolean keepCommentsInPom;
@Component
private DependencyResolver dependencyResolver;
@@ -408,7 +408,7 @@ public void execute()
File originalPomFile = this.project.getFile();
KeepCommentsInPom commentsOfOriginalPomFile = null;
- if (isKeepCommentsInPom()) {
+ if (keepCommentsInPom) {
commentsOfOriginalPomFile = KeepCommentsInPom.create(getLog(), originalPomFile);
}
Model flattenedPom = createFlattenedPom( originalPomFile );
@@ -1264,23 +1264,6 @@ public boolean isUpdatePomFile()
}
}
- /**
- * @return true
if the generated flattened POM shall have the comments of the original file
- * false
will remove the comments.
- */
- public boolean isKeepCommentsInPom()
- {
-
- if ( this.keepCommentsInPom == null )
- {
- return false;
- }
- else
- {
- return this.keepCommentsInPom.booleanValue();
- }
- }
-
/**
* This class is a simple SAX handler that extracts the first comment located before the root tag in an XML
* document.