Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in changes from byu-oit/generator-fullstack-app #694

Open
GaryGSC opened this issue Oct 26, 2022 · 2 comments
Open

Pull in changes from byu-oit/generator-fullstack-app #694

GaryGSC opened this issue Oct 26, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@GaryGSC
Copy link
Member

GaryGSC commented Oct 26, 2022

BYU's full stack team adapted this template repo for their own purposes as part of byu-oit/generator-fullstack-app (sorry, it's a private repo).

They probably created it to bake in some opinions (see #214). There are some things that look like bikeshedding at first glance (like renaming /terraform-iac to /iac) as well as some obvious enhancements, like what they're doing with test_env_var_overrides in their postman_test_lambda:

module "postman_test_lambda" {
  source   = "github.com/byu-oit/terraform-aws-postman-test-lambda?ref=v4.0.0"
  app_name = "${local.repo_name}-${var.env}"
  postman_collections = [
    {
      collection  = var.deploy_test_postman_collection
      environment = null
    }
  ]
  # set the context here so that we don't need 10+ environment.json files
  test_env_var_overrides = {
    context : "https://${module.my_fargate_api.dns_record.name}:4443"
  }
  role_permissions_boundary_arn = module.acs.role_permissions_boundary.arn
}

While we may or may not be able to include all of the opinions, I like the idea of keeping the codebases close together. There are some enhancements we can take from that repo and vice versa.

I'm open to the little changes like renaming /terraform-iac and I'd absolutely like to pull in the improvements like test_env_var_overrides. I think I see README improvements, too. I'd need to go through the commit history or look at the code with a fine-toothed comb, but it looks like the team has made good changes.

I'm treating this as a tracking issue. I may close it when the repos reach near-parity.

@GaryGSC GaryGSC added the enhancement New feature or request label Oct 26, 2022
@GaryGSC
Copy link
Member Author

GaryGSC commented Oct 28, 2022

Looking through the repo more closely, I see:

  • test_env_var_overrides
  • Some README improvements, like explaining docker-compose
  • Renaming some files and directories
  • Some application-specific code that we might not want to pull into this repo

@GaryGSC
Copy link
Member Author

GaryGSC commented Oct 31, 2022

I'm open to these changes, but I think I want to put them off for now.

We recently made a substantial number of improvements to this template, and we'd like applications that've already been created from this template to pick up the new changes. If we rename directories and files, we make the process more difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant