Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New LoadBrowserProcessSpecificV8Snapshot functionality in Electron #203

Open
jjeff opened this issue Jan 5, 2023 · 1 comment
Open

New LoadBrowserProcessSpecificV8Snapshot functionality in Electron #203

jjeff opened this issue Jan 5, 2023 · 1 comment

Comments

@jjeff
Copy link
Collaborator

jjeff commented Jan 5, 2023

I'm still trying to get my head around the new LoadBrowserProcessSpecificV8Snapshot Electron functionality and its relationship to Bytenode... and in particular, its relationship to V8 getting deprecated in Electron renderers.

Here are the release notes for Electron 22. Note also, the discussion around the issue that lead to this feature.

It looks like this only affects the main process for now And I'm trying to figure out what "Any other process will use the same path as is used today" means... But does this mean that we could load a Bytenode .jsc file into Electron directly without a loader file?

Anyway, just wanted to start a discussion here and see what this means from a Bytenode perspective.

@jjeff jjeff changed the title New LoadBrowserProcessSpecificV8Snapshot functionality in Electron New LoadBrowserProcessSpecificV8Snapshot functionality in Electron Jan 5, 2023
@OsamaAbbas
Copy link
Collaborator

OsamaAbbas commented Jan 5, 2023

Initial thoughts:

I have no clue what does the "path used today" part mean. Maybe it means that custom paths for the snapshot is not supported and you have to use the predefined one? I don't know.

For .jsc files to be loaded via this feature: I think at least they have to be compiled using the --no-module flag. Otherwise, even if they are loaded into context, they cannot run without the loader. They are just functions that need to be called in a specific way to get the module.exports populated ... etc.

But even with the --no-module flag, I doubt that they will work. They will likely fail the v8 sanity checks. We need to try and see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants