Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add performance diff test in github CI #413

Open
liuq19 opened this issue May 11, 2023 · 5 comments
Open

ci: add performance diff test in github CI #413

liuq19 opened this issue May 11, 2023 · 5 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@liuq19
Copy link
Collaborator

liuq19 commented May 11, 2023

We need add a performance diff test through the bench.py or other tools, and make it in github workflow.

@liuq19 liuq19 added the good first issue Good for newcomers label May 11, 2023
@sswastik02
Copy link

Hi @liuq19 ! I noticed this issue has been open for a while without any activity. I'd be interested in working on this.
I'd love to contribute and help move this forward.

@liuq19
Copy link
Collaborator Author

liuq19 commented Aug 28, 2023

Thanks, welcome to try it ~

@sswastik02
Copy link

sswastik02 commented Aug 31, 2023

Thank you for providing this opportunity to contribute.

We need add a performance diff test through the bench.py or other tools, and make it in github workflow.

However, it seems that the provided URL for the bench.py file does not lead to a valid GitHub file location. I have found bench.py, Just wanted to confirm if this is the one.

@liuq19
Copy link
Collaborator Author

liuq19 commented Sep 7, 2023

@sswastik02 yes, the file is bench.py

@sswastik02
Copy link

sswastik02 commented Sep 21, 2023

Hey @liuq19 , I tried running the file on my system, it takes a really long time to execute,
is there specific flags that i need to pass to it ?
Also is the performance diff mainly for the pull requests? as in the performance diff between branches ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants