Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dummy implementation of pretouch() for !amd64 arch #306

Merged
merged 4 commits into from Sep 28, 2022

Conversation

xiekeyi98
Copy link
Contributor

Closes: #301

@xiekeyi98 xiekeyi98 marked this pull request as ready for review September 26, 2022 06:04
@xiekeyi98 xiekeyi98 changed the title [WIP]: feat: 🎸 (sonic.go): Add none implement for !amd64 arch feat: 🎸 (sonic.go): Add none implement for !amd64 arch Sep 26, 2022
@xiekeyi98
Copy link
Contributor Author

@AsterDY Would you mind taking a look? Thanks!

Copy link
Collaborator

@AsterDY AsterDY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't add more go files. just use compat.go is enough

sonic_!amd64.go Outdated Show resolved Hide resolved
sonic_!amd64_test.go Outdated Show resolved Hide resolved
sonic_!amd64.go Outdated Show resolved Hide resolved
@AsterDY AsterDY changed the title feat: 🎸 (sonic.go): Add none implement for !amd64 arch feat: add none implementation of pretouch() for !amd64 arch Sep 27, 2022
@AsterDY AsterDY changed the title feat: add none implementation of pretouch() for !amd64 arch feat: add dummy implementation of pretouch() for !amd64 arch Sep 27, 2022
@AsterDY AsterDY merged commit b52e528 into bytedance:main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: add none implement for Pretouch under arm arch.
2 participants