fmt: move thrid-party tests into another module #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyn6315
requested review from
AsterDY,
liuq19 and
chenzhuoyu
and removed request for
liuq19
AsterDY
changed the title
|
fix #297 |
AsterDY
force-pushed
the
fix/move_benchmark
branch
from
fb2d8d4
to
60fa111
Compare
AsterDY
approved these changes
Sep 20, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move benchmarkTests and unitTests which reference external json libraries to the "external_jsonlib_test" folder and generate go.mod files for them to ensure that go.mod file in the sonic directory doesn't contain external json libraries.