feat:(option) add option MaxInlineDepth for addjust compilation inline depth
#287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsterDY
force-pushed
the
feat/inline_depth
branch
2 times, most recently
from
cc2b56d
to
8fdd4bd
Compare
AsterDY
force-pushed
the
feat/inline_depth
branch
from
78d594a
to
c0e28e4
Compare
liuq19
reviewed
Aug 22, 2022
liuq19
reviewed
Aug 22, 2022
| } else { | ||
| vt = reflect.PtrTo(vt) | ||
| } | ||
| if err := encoder.Pretouch(vt, opts...); err != nil { |
There was a problem hiding this comment.
- Pretouch() will pretouch concrete type and pointer type both for one call now
liuq19
approved these changes
Aug 22, 2022
liuq19
pushed a commit
that referenced
this pull request
Aug 29, 2022
…ine depth (#287) * feat: make compilation depth changeable * feat: add option `DefaultMaxInlineDepth` * add recurse depth = 10 * refactor * doc: readme and comment * opt: add `_MAX_FIELDS` to limit the inlining of big struct * update license * fix typo
liuq19
added a commit
that referenced
this pull request
Sep 20, 2022
* opt: faster f64toa * feat:(option) add option `MaxInlineDepth` for addjust compilation inline depth (#287) * feat: make compilation depth changeable * feat: add option `DefaultMaxInlineDepth` * add recurse depth = 10 * refactor * doc: readme and comment * opt: add `_MAX_FIELDS` to limit the inlining of big struct * update license * fix typo * feat:(ast) support cast `null` to empty value (#278) * fix: recompile * test: add ftoa benchmarks * feat: add f32toa * fix: add license * opt: optimize decimal * fix benchmarks * fix: poor performance in atof32 * test: add more integer test Co-authored-by: liuqiang <liuqiang.06@bytedance.com> Co-authored-by: Yi Duan <duanyi.aster@bytedance.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature
option.DefaultMaxInineDepthis changed to 3 instead of 5 and is changeable to useroption.DefaultRecurseDepthis changed to 1 instead of 0 and is changeable to userPretouch()will pretouch concrete type and pointer type both for one call now_MAX_FIELDSto limit inlining of big struct