Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read_u128_le() returns u16 instead of u128 #261

Open
spetz opened this issue Apr 16, 2024 · 2 comments
Open

read_u128_le() returns u16 instead of u128 #261

spetz opened this issue Apr 16, 2024 · 2 comments

Comments

@spetz
Copy link

spetz commented Apr 16, 2024

Hello,

I've started rewriting Iggy.rs into monoio runtime, as I'd like to see the potential benefits of io_uring along with TPC model (and compare the results with existing Tokio runtime), and I've found the following bug? in this line:

reader_trait!(ReadU128LEFuture, u16, read_u128_le);

It does return u16 instead of u128, while read_i128_le returns i128 - is there any reason why u128 isn't available? We use this for message IDs (e.g. UUID) and would like to stick to u128 if possible.

Cheers and thanks for the great work on this runtime!

@spetz spetz changed the title read_u128_le() returns u16 instead of u128` read_u128_le() returns u16 instead of u128 Apr 16, 2024
@ihciah
Copy link
Member

ihciah commented Apr 23, 2024

Yes it is a bug, sorry for that. Would like to help fix it?

@spetz
Copy link
Author

spetz commented Apr 28, 2024

Apologies for the delayed response, been a quite busy recently. I've seen it was fixed already, thanks @liuxin231 for the quick help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants