Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Duration be re-exported to allow for impl of HostWallClock? #8262

Open
alexanderkjeldaas opened this issue Mar 28, 2024 · 1 comment

Comments

@alexanderkjeldaas
Copy link

wasmtime-wasi/src/clocks.rs

use cap_std::time::Duration;

pub trait HostWallClock: Send {
    fn resolution(&self) -> Duration;
    fn now(&self) -> Duration;
}

Should Duration be exported from the wasi library to allow implementation of this trait?

@alexcrichton
Copy link
Member

I believe cap_std::time::Duration is itself a reexport of std::time::Duration, although adding a reexport to wasmtime-wasi also seems ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants