Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-vet: audit base64 0.21.0 #5707

Merged
merged 1 commit into from
Feb 4, 2023
Merged

cargo-vet: audit base64 0.21.0 #5707

merged 1 commit into from
Feb 4, 2023
+6 −0

Conversation

pchickey
Copy link
Contributor

@pchickey pchickey commented Feb 4, 2023 •
edited
Loading

For #5702

@alexcrichton alexcrichton enabled auto-merge (squash) February 4, 2023 00:37
jameysharp
jameysharp approved these changes Feb 4, 2023
View reviewed changes
Copy link
Contributor

@jameysharp jameysharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you did a full audit rather than a delta audit, which is maybe more work than strictly necessary, but definitely good enough.

@pchickey
Copy link
Contributor Author

pchickey commented Feb 4, 2023

This was a particularly easy crate to audit (it was enjoyable to skim, there are lots of good comments!) and also i didn't figure out how to do a delta audit. I will have to learn that next time!

@pchickey pchickey mentioned this pull request Feb 4, 2023
Merged
3 tasks
@alexcrichton alexcrichton merged commit 331bc28 into main Feb 4, 2023
@alexcrichton alexcrichton deleted the pch/vet_base64 branch February 4, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton

@jameysharp jameysharp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pchickey @alexcrichton @jameysharp