Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precompiled gem for Ruby 3.2 #103

Closed
jbourassa opened this issue Jan 2, 2023 · 4 comments
Closed

Precompiled gem for Ruby 3.2 #103

jbourassa opened this issue Jan 2, 2023 · 4 comments
Assignees

Comments

@jbourassa
Copy link
Collaborator

wasmtime-rb v0.4.1 works on Ruby 3.2, but requires compiling from source. The latest release aimed to solve that, but it didn't work: the .gem does not have a precompiled bundle for 3.2. After investigating, we are indeed including 3.2 in the list of rubies to precompile for (ruby-versions: 2.7, 3.0, 3.1, 3.2). I think the culprit is rake-compiler-dock (RCD) not yet supporting Ruby 3.2.

We should be able to specify a Docker image in a ENV var, similar to what Mike did for SQLite and Nokogiri. That, or wait until the next RCD release.

@jbourassa jbourassa self-assigned this Jan 2, 2023
@jbourassa
Copy link
Collaborator Author

jbourassa commented Jan 3, 2023

We should be able to specify a Docker image in a ENV var

That won't work: rb-sys uses RCD's images to build its own images, and then injects those as RCD_IMAGE.

Also, we'd have to change the extconf to do add append_ldflags("-Wl,-flat_namespace").

Might as well wait for this to be fixed in rake-compiler-dock, wait for a new release, and then bump everything.

@ianks
Copy link
Collaborator

ianks commented Jan 17, 2023

Ruby 3.2 images are up now. Do they work?

@jbourassa
Copy link
Collaborator Author

Yes it works, I just need to cut a release now. I'm planning on release v5.0.0 with when Wasmtime 5.0 hits which should be around the 20th.

@jbourassa
Copy link
Collaborator Author

Fixed as of v5.0.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants