Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasm-encoder: Change the I64xLeS instruction encoding #811

Merged
merged 1 commit into from Nov 9, 2022
Merged

wasm-encoder: Change the I64xLeS instruction encoding #811

merged 1 commit into from Nov 9, 2022

Conversation

adambratschikaye
Copy link
Contributor

Change the u32 field of the I64x2LeS instruction from 0xDD to 0xDA (decimal 218) to match the spec.

@adambratschikaye
Change the I64xLeS instruction encoding
9fa7adf 
Change the u32 field of the I64x2LeS instruction from 0xDD to 0xDA to
match the spec.
@adambratschikaye adambratschikaye changed the title Change the I64xLeS instruction encoding wasm-encoder: Change the I64xLeS instruction encoding Nov 9, 2022
@adambratschikaye
Copy link
Contributor Author

This should fix #812.

alexcrichton
alexcrichton approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@alexcrichton alexcrichton merged commit 290f4bc into bytecodealliance:main Nov 9, 2022
@alexcrichton alexcrichton mentioned this pull request Nov 9, 2022
Closed
@adambratschikaye
Copy link
Contributor Author

Thanks for taking a look. By the way, any idea when the next release would be?

@adambratschikaye adambratschikaye deleted the change-I64x2LeS-encoding branch November 9, 2022 15:16
@alexcrichton
Copy link
Member

I'm preparing that in #815

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adambratschikaye @alexcrichton