Simplify API for parsing the name section #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modernizes the API to parse the `name` section in `wasmparser`, notably leveraging existing traits and removing some indirection through extra structures. The intent is to enable iterator-based parsing similar to the rest of parsing items in this crate, meaning the same idioms can be used for the `name` section as all other sections. At the same time this commit also adds a new subcommand I thought of recently as `wasm-tools demangle` which runs a Rust or C++ demangler over the `name` section. This is almost guaranteed to increase the size of the `name` section but it otherwise might be useful when interacting with tools that don't otherwise demangle names automatically, for example web or JS runtimes.
pchickey
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modernizes the API to parse the
namesection inwasmparser, notably leveraging existing traits and removing some indirection through extra structures. The intent is to enable iterator-based parsing similar to the rest of parsing items in this crate, meaning the same idioms can be used for thenamesection as all other sections.At the same time this commit also adds a new subcommand I thought of recently as
wasm-tools demanglewhich runs a Rust or C++ demangler over thenamesection. This is almost guaranteed to increase the size of thenamesection but it otherwise might be useful when interacting with tools that don't otherwise demangle names automatically, for example web or JS runtimes.