Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Cell for fuel in wasm-mutate #789

Merged
merged 2 commits into from Oct 4, 2022

Conversation

alexcrichton
Copy link
Member

This commit removes the Cell used in fuel by taking &mut self instead of &self. Two locations needed to be updated to handle this mutability and weren't too hard to refactor.

This commit removes the `Cell` used in fuel by taking `&mut self`
instead of `&self`. Two locations needed to be updated to handle this
mutability and weren't too hard to refactor.
@alexcrichton
Copy link
Member Author

The motivation for this change is that clap in 4.0.0 does not support non-Sync arguments and looks like it won't plan on doing so any time soon, so in the interest of still being upgrade this performs the refactor here.

@alexcrichton alexcrichton merged commit 7970131 into bytecodealliance:main Oct 4, 2022
@alexcrichton alexcrichton deleted the no-cell branch October 4, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants