OperatorVisitor: qualify index param names #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, it is going to affect the definitions of the Well, I think it is still worth trying to make this change tbh, so I’ll adjust. |
nagisa
changed the title
This is intended to make it easier for implementers of this trait to figure what is what (admittedly `index` doesn’t say much when there are all kinds of indexable lists, and some entities deal with indices into multiple lists), especially if they’re using something like RLS’ auto-implement all methods or just reading the documentation. With `type_index` and `tag_index` these parameters become self-documenting.
Robbepop
approved these changes
Sep 16, 2022
alexcrichton
approved these changes
Sep 16, 2022
|
Agreed, thank you for these improvements! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to make it easier for implementers of this trait to figure what is what (admittedly
indexdoesn’t say much when there are all kinds of indexable lists, and some entities deal with indices into multiple lists), especially if they’re using something like RLS’ auto-implement all methods or just reading the documentation.With
type_indexandtag_indexthese parameters become self-documenting.