Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasmparser: self-contain for_each_operator! #764

Merged
merged 1 commit into from Sep 8, 2022

Conversation

nagisa
Copy link
Contributor

@nagisa nagisa commented Sep 8, 2022

This adjusts the for_each_operator! macro to avoid it requiring ambient context (imports) with specific names. Instead it’ll use correctly-scoped fully qualified names, making it somewhat easier to use.

Copy link
Contributor

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice usability improvement!

Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks! I think that this may need a rebase though.

This adjusts the `for_each_operator!` macro to avoid it requiring
ambient context (imports) with specific names. Instead it’ll use
correctly-scoped fully qualified names, making it somewhat easier to
use.
@alexcrichton alexcrichton merged commit 609dc15 into bytecodealliance:main Sep 8, 2022
@nagisa nagisa deleted the self-contained-feo branch September 9, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants