Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the spec test suite submodule #763

Merged
merged 4 commits into from Sep 21, 2022

Conversation

alexcrichton
Copy link
Member

This commit updates the tests/testsuite submodule which is a copy of the spec tests from upstream and the various proposals repositories. The major change included here is the update to the lexing of the text format to allow "reserved" tokens to have string tokens embedded within them (in a sense). This doesn't affect any parsing in the crate, only the tokenization of the input.

Additionally there are a few minor updates to error messages plus an new exceptional case where the spec interpreter is printing "unknown global" for defined globals which I'm not really sure what's going on.

This commit updates the `tests/testsuite` submodule which is a copy of
the spec tests from upstream and the various proposals repositories. The
major change included here is the update to the lexing of the text
format to allow "reserved" tokens to have string tokens embedded within
them (in a sense). This doesn't affect any parsing in the crate, only
the tokenization of the input.

Additionally there are a few minor updates to error messages plus an
new exceptional case where the spec interpreter is printing "unknown
global" for defined globals which I'm not really sure what's going on.
@alexcrichton
Copy link
Member Author

I've now additionally updated this to include the inclusion of relaxed-simd into the testsuite repo as well.

@alexcrichton alexcrichton merged commit f9a5709 into bytecodealliance:main Sep 21, 2022
@alexcrichton alexcrichton deleted the update-testsuite branch September 21, 2022 16:23
@dkegel-fastly
Copy link

dkegel-fastly commented Sep 22, 2022

This seems to bump the minimum supported rust compiler; I'm now getting

#25 101.6   --> /root/.cargo/registry/src/github.com-1ecc6299db9ec823/wast-47.0.0/src/names.rs:84:26
#25 101.6    |
#25 101.6 84 |         format!("unknown {ns}: failed to find name `${}`", id.name()),
#25 101.6    |                          ^^^^

in a dockerfile that had been working, so my little downstream project's unhappy now.

I guess I get to update it from alpine 3.15; I was about to anyway for other reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants