Add the ability to share allocations during validation #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds API support to the function validation portion of `wasmparser` to share allocations amongst validation of different functions. This is done by adding a `FuncToValidate` step which is prior to creating a `FuncValidator` and creation of a `FuncValidator` happens when it's fused with a new type, `FuncValidatorAllocations`. The allocations can be retrieved by consuming the validator as well. Locally in the benchmarks this yields a 5-15% performance increase depending on the benchmark. Closes bytecodealliance#714
fitzgen
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds API support to the function validation portion of
wasmparserto share allocations amongst validation of differentfunctions. This is done by adding a
FuncToValidatestep which is priorto creating a
FuncValidatorand creation of aFuncValidatorhappenswhen it's fused with a new type,
FuncValidatorAllocations. Theallocations can be retrieved by consuming the validator as well.
Locally in the benchmarks this yields a 5-15% performance increase
depending on the benchmark.
Closes #714