Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasm-encoder: remove iterator-based encoders. #612

Merged
merged 1 commit into from May 18, 2022
Merged

wasm-encoder: remove iterator-based encoders. #612

merged 1 commit into from May 18, 2022

Conversation

peterhuene
Copy link
Member

This PR removes the iterator-based encoding functions from wasm-encoder
in favor of implementing Encode on primitive types.

@peterhuene
Copy link
Member Author

I'll rebase and merge this after we merge the other approved PRs just to make sure the added test coverage from those changes does not break.

@peterhuene
wasm-encoder: remove iterator-based encoders.
f86177e 
This commit removes the iterator-based encoding functions from `wasm-encoder`
in favor of implementing `Encode` on primitive types.
@peterhuene peterhuene merged commit 16af83e into bytecodealliance:main May 18, 2022
@peterhuene peterhuene deleted the remove-encoders branch May 18, 2022 23:55
code-terror pushed a commit to code-terror/wasm-tools that referenced this pull request Aug 24, 2022
@peterhuene @code-terror
wasm-encoder: remove iterator-based encoders. (bytecodealliance#612)
2d03ebf 
This commit removes the iterator-based encoding functions from `wasm-encoder`
in favor of implementing `Encode` on primitive types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterhuene @alexcrichton