Remove ItemRef and IndexOrRef from core wast support
#608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These constructs are vestiges of the old module linking proposal where any reference to any item could be replaced with `(kind $instance "export")` as sugar for injectin aliases. At this time core wasm does not support nested instances so this removes the support in the `wast` crate to bring the core wasm support more in line with the specification.
peterhuene
approved these changes
May 18, 2022
code-terror
pushed a commit
to code-terror/wasm-tools
that referenced
this pull request
Aug 24, 2022
…lliance#608) These constructs are vestiges of the old module linking proposal where any reference to any item could be replaced with `(kind $instance "export")` as sugar for injectin aliases. At this time core wasm does not support nested instances so this removes the support in the `wast` crate to bring the core wasm support more in line with the specification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These constructs are vestiges of the old module linking proposal where
any reference to any item could be replaced with
(kind $instance "export")as sugar for injectin aliases. At this timecore wasm does not support nested instances so this removes the support
in the
wastcrate to bring the core wasm support more in line with thespecification.