Add more tests exercising the component model #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly adding tests for invalid constructs in the component model to ensure that wasmparser generates the right error in the future during refactorings. Additionally some miscellaneous items are fixed along the way: * Some dead code in wasmparser was removed * The type check error message for component functions was fixed when results mismatch. * The `wast` crate is a little more lax about `alias` statements that are clearly out of bounds (lets `wasmparser` generate the error instead). * Parsing support for `(component quote "...")` was added
peterhuene
approved these changes
May 18, 2022
code-terror
pushed a commit
to code-terror/wasm-tools
that referenced
this pull request
Aug 24, 2022
This is mostly adding tests for invalid constructs in the component model to ensure that wasmparser generates the right error in the future during refactorings. Additionally some miscellaneous items are fixed along the way: * Some dead code in wasmparser was removed * The type check error message for component functions was fixed when results mismatch. * The `wast` crate is a little more lax about `alias` statements that are clearly out of bounds (lets `wasmparser` generate the error instead). * Parsing support for `(component quote "...")` was added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly adding tests for invalid constructs in the component
model to ensure that wasmparser generates the right error in the future
during refactorings. Additionally some miscellaneous items are fixed
along the way:
results mismatch.
wastcrate is a little more lax aboutaliasstatements thatare clearly out of bounds (lets
wasmparsergenerate the errorinstead).
(component quote "...")was added