Add more tests for components parsing #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit uses coverage to find holes in where we weren't testing
parser support for a feature in the component model. Additionally some
AST changes were made along the way:
* The `wasmprinter` output for canonical abi options were tweaked:
* string-related options are prefixed with `string=`
* the `into` option no longer prints `(instance ...)`, it only prints
the instance index
* The name of parameters in function types was changed to a `&str` from
the id/name annotation combo.
* A number of unused `Peek` implementations were removed.
* Some dynamically dead code was replaced with `unreachable!` to
emphasize it shouldn't be executed.
* A subtraction-overflow issue was fixed in name resolution for outer
aliases which try to reach too far.
* Parsing `ComponentTypeUse` as a simple index like `$foo` was removed
as it's expected to either be `(type $idx)` or an inline definition.
peterhuene
approved these changes
May 16, 2022
code-terror
pushed a commit
to code-terror/wasm-tools
that referenced
this pull request
Aug 24, 2022
This commit uses coverage to find holes in where we weren't testing
parser support for a feature in the component model. Additionally some
AST changes were made along the way:
* The `wasmprinter` output for canonical abi options were tweaked:
* string-related options are prefixed with `string=`
* the `into` option no longer prints `(instance ...)`, it only prints
the instance index
* The name of parameters in function types was changed to a `&str` from
the id/name annotation combo.
* A number of unused `Peek` implementations were removed.
* Some dynamically dead code was replaced with `unreachable!` to
emphasize it shouldn't be executed.
* A subtraction-overflow issue was fixed in name resolution for outer
aliases which try to reach too far.
* Parsing `ComponentTypeUse` as a simple index like `$foo` was removed
as it's expected to either be `(type $idx)` or an inline definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit uses coverage to find holes in where we weren't testing
parser support for a feature in the component model. Additionally some
AST changes were made along the way:
wasmprinteroutput for canonical abi options were tweaked:string=intooption no longer prints(instance ...), it only printsthe instance index
&strfromthe id/name annotation combo.
Peekimplementations were removed.unreachable!toemphasize it shouldn't be executed.
aliases which try to reach too far.
ComponentTypeUseas a simple index like$foowas removedas it's expected to either be
(type $idx)or an inline definition.