Simplify RawDir iteration #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
|
Makes sense! |
sunfishcode
pushed a commit
that referenced
this pull request
Jan 17, 2023
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com> Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
sunfishcode
pushed a commit
that referenced
this pull request
Jan 17, 2023
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com> Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently had to look at this again and unsurprisingly I have no idea what past me was thinking. 馃槄
Basic idea: get rid of the loop. It ain't needed.
New control flow:
0 >= 0), we need to refill the buffer.initializedandoffsetonly ever need to be reset when we actually succeeded in filling the buffer. On an error, we return which means that ifnextgets called again, theoffset >= initializedcheck will run again with the same result since nothing changed.Note: the diff is overcomplicating things, the main change is just swapping where the syscall and buffer consumption occur.