Add mount syscall #494
Merged
Add mount syscall #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
reviewed
Jan 6, 2023
There was a problem hiding this comment.
I was a little uncertain at first at providing higher level APIs instead of just exposing the syscall, but I think you have captured all the use cases I can think of. (I looked through man 8 mount for the high level operations)
So a somewhat superficial LGTM.
|
Cool beans, as long as we agree on the API surface we can muck around with the flags later if they become an issue. |
|
Every nightly check is currently broken because of a missing fuschia build. |
|
The fuchsia fix is now on main, so rebasing on main should fix the CI here. I also don't have time today to review this, but at a superficial glance this looks good. |
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
|
Yeep, fixed. |
|
Looks good, thanks! |
|
Woohoo! Unmount: #512 |
sunfishcode
pushed a commit
that referenced
this pull request
Jan 17, 2023
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com> Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
sunfishcode
pushed a commit
that referenced
this pull request
Jan 17, 2023
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com> Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My flag management is absolutely terrible, any suggestions would be appreciated. :) The goal is to try and only provide applicable flags (which is maybe a hopeless cause), but that means having partially overlapping sets thereby complicating everything. Also,
StatVfsMountFlagsare related, not sure if we should somehow combine things.In another PR, I'll add umount.
Closes #491