New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isatty
is not required to set errno
#467
Comments
sunfishcode
added a commit
that referenced
this issue
Nov 30, 2022
We don't actually do anything different for different errno values, other than panic on unknown ones, and that isn't that isn't adding much value compared to the cost of being an extra surprise when porting to new OS's. Fixes #467.
Makes sense to me. I've now submitted #468 to only look at the return value, and not |
Thanks! ❤️ |
sunfishcode
added a commit
that referenced
this issue
Dec 1, 2022
We don't actually do anything different for different errno values, other than panic on unknown ones, and that isn't that isn't adding much value compared to the cost of being an extra surprise when porting to new OS's. Fixes #467.
sunfishcode
added a commit
that referenced
this issue
Dec 5, 2022
We don't actually do anything different for different errno values, other than panic on unknown ones, and that isn't that isn't adding much value compared to the cost of being an extra surprise when porting to new OS's. Fixes #467.
sunfishcode
added a commit
that referenced
this issue
Dec 5, 2022
We don't actually do anything different for different errno values, other than panic on unknown ones, and that isn't that isn't adding much value compared to the cost of being an extra surprise when porting to new OS's. Fixes #467.
luqmana
added a commit
to luqmana/rust
that referenced
this issue
Dec 9, 2022
Pull in fix for bytecodealliance/rustix#467 on recent cargo nightlies.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Dec 10, 2022
…ulacrum Update rustix to 0.36.5 Pull in fix for bytecodealliance/rustix#467 on recent cargo nightlies.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Dec 10, 2022
…ulacrum Update rustix to 0.36.5 Pull in fix for bytecodealliance/rustix#467 on recent cargo nightlies.
This was referenced Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi! We noticed that the nightly version of
cargo
is panicking inside rustix on illumos:Digging in a bit, we found that the issue is that illumos currently chooses not to set errno in
isatty()
, but rustix expects errno to be set to ENOTTY ifisatty()
returns 0, and panics otherwise. I think illumos's behavior here is not ideal (and we're also filing a bug there), but is technically allowed by the wording on the POSIX manpage (emphasis mine):Would you be opposed to changing the implementation of
isatty()
to only look at the return value and not errno?The text was updated successfully, but these errors were encountered: