Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getpgid #380

Merged
merged 4 commits into from Jul 13, 2022
Merged

Add getpgid #380

merged 4 commits into from Jul 13, 2022

Conversation

carbotaniuman
Copy link
Contributor

No description provided.

sunfishcode
sunfishcode reviewed Jul 11, 2022
View reviewed changes
Copy link
Member

@sunfishcode sunfishcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiousity, is this for the bat command? If so, I'm curious where the call actually comes from, and if they're using to get the current process group (the None case) or another process group.

src/process/id.rs Outdated Show resolved Hide resolved
@carbotaniuman
Copy link
Contributor Author

Out of curiousity, is this for the bat command?

Yup! The call appears to bottom out in libgit2's rand.c calculating a seed. I think everything basically just wants the getpgrp case where pid is None.

@sunfishcode sunfishcode merged commit 1ceb659 into bytecodealliance:main Jul 13, 2022
@carbotaniuman carbotaniuman deleted the getpgid branch December 8, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunfishcode sunfishcode sunfishcode left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carbotaniuman @sunfishcode