Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Are TypeScript definitions generated by transpile supposed to include comments from the WIT file? #397

Open
blaine-arcjet opened this issue Mar 7, 2024 · 2 comments
Open

Are TypeScript definitions generated by transpile supposed to include comments from the WIT file? #397

blaine-arcjet opened this issue Mar 7, 2024 · 2 comments

Comments

@blaine-arcjet
Copy link

I found #94 which fixed the TypeScript generation and it mentions comments, but I can't seem to get the comments I defined in my .wit file to actually show up when I use jco transpile. Is this something that is supported?
@guybedford
Copy link
Collaborator

Yes TypeScript output includes the comments from WIT. If you have an example of what specific doc comments are being missed in translation that would be great to track.

@blaine-arcjet
Copy link
Author

Interesting! I'm not getting any comments but the current stuff isn't open source. Let me create a reproduction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guybedford @blaine-arcjet