Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In mqttc v5, restore session only if session is resumed #863

Closed
xiaocq2001 opened this issue May 11, 2024 · 1 comment
Closed

In mqttc v5, restore session only if session is resumed #863

xiaocq2001 opened this issue May 11, 2024 · 1 comment
Assignees
@de-sh @xiaocq2001

Comments

@xiaocq2001
Copy link
Contributor

Current Behavior

Currently rumqttc for MQTTv5 always republish packets which aren't acked, no matter it's clean session or resume session.

Expected Behavior

For simple we can use the session_present in CONNACK returned by broker, if it's 1 the session is resumed, if it's 0 the session is new and the pending requests should be discarded.
@xiaocq2001 xiaocq2001 mentioned this issue May 14, 2024
Merged
2 tasks
@xiaocq2001 xiaocq2001 changed the title In v5, restore session only if session is resumed In mqttc v5, restore session only if session is resumed May 14, 2024
@de-sh
Copy link
Member

de-sh commented May 14, 2024

@swanandx does broker by default set this correctly?

@de-sh de-sh closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@de-sh de-sh

@xiaocq2001 xiaocq2001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@de-sh @xiaocq2001