Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rumqttc - ack with reason code #841

Open
ting-ms opened this issue Apr 7, 2024 · 3 comments
Open

rumqttc - ack with reason code #841

ting-ms opened this issue Apr 7, 2024 · 3 comments

Comments

@ting-ms
Copy link

ting-ms commented Apr 7, 2024

Does rumqttc support replay ack with a reason code?

@swanandx
Copy link
Member

swanandx commented Apr 9, 2024

Hey, rumqttc doesn't support it right now, but would be nice to have!

also there is #609 , I'm thinking we can modify ack fn to take Ack as suggested in issue description, wdyt?

Thank you so much!

@ting-ms
Copy link
Author

ting-ms commented Apr 10, 2024

If we are going to add a new API such as get_ack_packet(&Publish) -> Ack, we could consider adding additional parameters, such as PubAckReason and PubAckProperties, and then modify the ack function to accept Ack as its argument.

@xiaocq2001
Copy link
Contributor

Proposed some solution with ack packet, please check: #855

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants