feat: Added AUTH packet support for enhanced authentication. #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-sh
reviewed
May 29, 2024
| options.keep_alive = Duration::from_secs(keep_alive as u64); | ||
| } | ||
| network.set_max_outgoing_size(props.max_packet_size); | ||
| loop { |
There was a problem hiding this comment.
There are two ways to do this, one as has been already implemented in this PR, the other would involve improving the visibility into the whole process, updating the event log and returning events as they occur.
Example log of events
- Outgoing Connect packet
- Incoming/Outgoing Auth packets for as long as the challenge/response cycle goes on
- Incoming Connack packet
This would require a refactor of how the code is currently structured, let me delve deeper into this.
de-sh
reviewed
May 29, 2024
Please reference the following docs for the testing guidance: |
… chxiao/auth_support
Update auth_continue API.
|
Attached updated design doc. |
Fix Send issue between threads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
New feature (non-breaking change which adds functionality)
Checklist:
cargo fmtCHANGELOG.mdif it's relevant to the users of the library. If it's not relevant mention why.Resolves #840