refactor!: Remove Connect from ConnectionError::StateError
#541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h3nill
force-pushed
the
fix-connectionerror
branch
from
bb308d1
to
edd7ba4
Compare
h3nill
changed the title
|
This seems like the opposite of what we should be doing. Since connection refusals have nothing to do with MQTT state, we have to remove the |
h3nill
force-pushed
the
fix-connectionerror
branch
from
a2a971b
to
4d9f995
Compare
h3nill
force-pushed
the
fix-connectionerror
branch
from
4d9f995
to
19205bf
Compare
h3nill
changed the title
Connect from ConnectionError::StateError
carlocorradini
pushed a commit
to carlocorradini/rumqtt
that referenced
this pull request
Aug 3, 2023
…eamio#541) * refactor!: remove `Connect` from `ConnectionError::StateError` * fix clippy warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConnectionErrorhas a variant namedConnectionRefusedwhich should be used instead.