chore(rumqttd): Make tracing events human-readable #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Re-organize spans basis of importance of context information they carry.
The span tree has three levels. Level 0 has coarse, high-level information.
Level 2 has fine, low-level information. The tree looks like:
|- incoming (level 0)
| |- incoming_connect (level 1)
| |- incoming_payload
| | |- publish (level 2)
| | |- subscribe
| | |- ...
| |- incoming_disconnect
|- outgoing (level 0)
| |- outgoing_ack (level 1)
| |- outgoing_publish
- Refactor `routing::forward_device_data()`
- Make tracing events more human-readable
- Remove fields from tracing events that are present in enclosing tracing
spans
mnpw
changed the title
carlocorradini
pushed a commit
to carlocorradini/rumqtt
that referenced
this pull request
Aug 3, 2023
* chore(rumqttd): add more tracing, make tracing events human-readable
- Re-organize spans basis of importance of context information they carry.
The span tree has three levels. Level 0 has coarse, high-level information.
Level 2 has fine, low-level information. The tree looks like:
|- incoming (level 0)
| |- incoming_connect (level 1)
| |- incoming_payload
| | |- publish (level 2)
| | |- subscribe
| | |- ...
| |- incoming_disconnect
|- outgoing (level 0)
| |- outgoing_ack (level 1)
| |- outgoing_publish
- Refactor `routing::forward_device_data()`
- Make tracing events more human-readable
- Remove fields from tracing events that are present in enclosing tracing
spans
* Update tracing event messages
* Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance tracing in rumqttd
Refactor(Added refactor(router): Refactor forward_device_data() #507 for this)routing::forward_device_data()Make tracing events more human-readable
Remove fields from tracing events that are present in enclosing tracing spans