Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enter runtime context for now_or_never() within try_recv #497

Merged
merged 4 commits into from Nov 14, 2022
Merged

Conversation

de-sh
Copy link
Member

@de-sh de-sh commented Nov 9, 2022

Closes #496

Enter the runtime context within Connection::try_recv() in order to allow the creation and passing of a noop waker for the instantaneous polling of associated future.

@de-sh
Copy link
Member Author

de-sh commented Nov 9, 2022

The errors seem to be caused by new linting rule additions to clippy

* Simplify code, remove `_guard` and create timeout within async closure
* Add example usacases
@de-sh de-sh merged commit 53b2dac into main Nov 14, 2022
@de-sh de-sh deleted the enter-ctx branch November 14, 2022 16:23
carlocorradini pushed a commit to carlocorradini/rumqtt that referenced this pull request Aug 3, 2023
…tebeamio#497)

* fix: enter runtime context for `now_or_never()`
* feat: cleanup code and add usage examples
* Simplify code, remove `_guard` and create timeout within async closure
* Add example use-cases
* doc: add changelog for PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can the sync API be used without a tokio reactor?
1 participant