fix(protocol): Extract out Disconnect packet logic similar to other packets #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h3nill
force-pushed
the
disconnect-packet
branch
from
853ec8a
to
3742603
Compare
|
(ci failing for reasons that are fixed in #476) |
h3nill
force-pushed
the
disconnect-packet
branch
from
eef5f11
to
db77486
Compare
…dentified just from its packet type
mnpw
pushed a commit
that referenced
this pull request
Oct 29, 2022
carlocorradini
pushed a commit
to carlocorradini/rumqtt
that referenced
this pull request
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add optional properties to
unsubscribe,unsubackandconnackpacket, so its consistent with other packets.