fix(v5): send last_will and login info with connect #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What needs to happen to get this merged? The build failures don't seem to have anything to do with the changes. |
brianmay
approved these changes
Dec 17, 2022
h3nill
force-pushed
the
hotfix-v5-fields
branch
from
57da1da
to
d49f8c1
Compare
|
I was working on refactoring rumqttc so we wouldn't need this hotfix but it turned out to be alot more work than i expected (also would require some breaking changes). So that was deprioritized atm, then I was not available for a month due to personal reasons in which this PR got buried down. Merging it now. |
carlocorradini
pushed a commit
to carlocorradini/rumqtt
that referenced
this pull request
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #473