Make rumqttc::client::Iter public #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, failure seems like a flaky test? |
|
Hey @kelnos, it seems that calling it |
de-sh
reviewed
Jun 9, 2022
kelnos
force-pushed
the
public-connection-iter
branch
from
27b7384
to
5ed3b51
Compare
|
Oh hm, looks like |
kelnos
force-pushed
the
public-connection-iter
branch
from
5ed3b51
to
254c882
Compare
kelnos
force-pushed
the
public-connection-iter
branch
from
254c882
to
77beb7b
Compare
|
Ok, updated for current master. Did the same for the |
de-sh
approved these changes
Jun 10, 2022
|
Wohoo @kelnos, congrats on the merge! 🥳 |
Closed
carlocorradini
pushed a commit
to carlocorradini/rumqtt
that referenced
this pull request
Aug 3, 2023
Make rumqttc::client::Iter public
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this is perhaps a little esoteric, but in order to implement some foreign traits (https://docs.rs/embedded-svc/0.21.2/embedded_svc/mqtt/client/trait.Connection.html), I need to be able to wrap the
Iterreturned byrumqttc::Connection.iter(). Maybe there are some arcane tricks to do this using a trait object overIterator, but if there are, I haven't been able to get it to work right, and, regardless, it's incredibly awkward. Much more straightforward would be to be able to just embed the actual type ofIterinto my struct, but I can't because it's declared only in a private module.