Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rumqttc v5 #351

Merged
merged 50 commits into from May 11, 2022
Merged

rumqttc v5 #351

merged 50 commits into from May 11, 2022

Conversation

abhikjain360
Copy link
Contributor

@abhikjain360 abhikjain360 commented Feb 12, 2022

Add supports for MQTTv5 to rumqttc, along with following changes (only in v5, v4 not changed):

  • Use Arc<Mutex<VecDeque<Request>>> instead of async-channel to send requests from client to eventloop
  • pkids are returned when calling subscribe from client.
  • code for parsing v5 packets copied from mqttbytes, remove its use
  • use flume instead of async_channel and pollster
  • different (and hopefully more intuitive) APIs, with option to run eventloop in background by default
  • No longer supporting informing about outgoing events via eventloop

Signed-off-by: Abhik Jain <abhikjain360@gmail.com>
Signed-off-by: Abhik Jain <abhikjain360@gmail.com>
Signed-off-by: Abhik Jain <abhikjain360@gmail.com>
Signed-off-by: Abhik Jain <abhikjain360@gmail.com>
Signed-off-by: Abhik Jain <abhikjain360@gmail.com>
Signed-off-by: Abhik Jain <abhikjain360@gmail.com>
Signed-off-by: Abhik Jain <abhikjain360@gmail.com>
Signed-off-by: Abhik Jain <abhikjain360@gmail.com>
Signed-off-by: Abhik Jain <abhikjain360@gmail.com>
@abhikjain360 abhikjain360 marked this pull request as draft February 12, 2022 13:47
Signed-off-by: Abhik Jain <abhikjain360@gmail.com>
@abhikjain360 abhikjain360 marked this pull request as ready for review February 14, 2022 08:17
@abhikjain360 abhikjain360 marked this pull request as draft February 14, 2022 08:20
Signed-off-by: Abhik Jain <abhikjain360@gmail.com>
Signed-off-by: Abhik Jain <abhikjain360@gmail.com>
Signed-off-by: Abhik Jain <abhikjain360@gmail.com>
Signed-off-by: Abhik Jain <abhikjain360@gmail.com>
@de-sh de-sh mentioned this pull request Mar 3, 2022
Closed
@de-sh
Copy link
Member

de-sh commented Mar 10, 2022

NOTE: GitHub action fails since the PR doesn't contain the changes included in master that are necessary to run cargo-clippy with RUSTFLAGS="-D warnings". Consider only cargo-test(offline) results for PR merge.

Update, Mar 13:
Also, seems like 75 millis is not good enough Deviation for some test runs on macos, case in point.

Signed-off-by: Abhik Jain <abhikjain360@gmail.com>
Signed-off-by: Abhik Jain <abhikjain360@gmail.com>
Signed-off-by: Abhik Jain <abhikjain360@gmail.com>
Signed-off-by: Abhik Jain <abhikjain360@gmail.com>
Signed-off-by: Abhik Jain <abhikjain360@gmail.com>
@flxo
Copy link
Contributor

flxo commented Mar 24, 2022

Hello @abhikjain360

just a quick question to be sure: Your plan is to support v5 in a complete separated way from v4? Means a client needs to decide at build time which version to use? Any plans to add the possibility to choose the protocol version at runtime?

Thanks!

Signed-off-by: Abhik Jain <abhikjain360@gmail.com>
Signed-off-by: Abhik Jain <abhikjain360@gmail.com>
Signed-off-by: Abhik Jain <abhikjain360@gmail.com>
…::next()`

Signed-off-by: Abhik Jain <abhikjain360@gmail.com>
Signed-off-by: Abhik Jain <abhikjain360@gmail.com>
@tekjar
Copy link
Contributor

tekjar commented Mar 25, 2022

They'll completely be separate for now @flxo. Helps us move faster

Signed-off-by: Abhik Jain <abhikjain360@gmail.com>
Signed-off-by: Abhik Jain <abhikjain360@gmail.com>
Signed-off-by: Abhik Jain <abhikjain360@gmail.com>
Signed-off-by: Abhik Jain <abhikjain360@gmail.com>
Signed-off-by: Abhik Jain <abhikjain360@gmail.com>
@stale stale bot added the stale Not moving forward; blocked label Apr 21, 2022
@mladedav
Copy link
Contributor

mladedav commented May 2, 2022

Hi, I just want to check on this and provide support if needed. I am interested in getting packet IDs for which I understand this is a prerequisite.

Last commit here is a month old so I am just wondering if this is still being worked on or someone should pick it up.

@stale stale bot removed the stale Not moving forward; blocked label May 2, 2022
@de-sh de-sh changed the base branch from master to fix-v5 May 11, 2022 17:05
@de-sh de-sh merged commit 8b42117 into bytebeamio:fix-v5 May 11, 2022
This was referenced May 11, 2022
Closed
carlocorradini pushed a commit to carlocorradini/rumqtt that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants