Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example of emojiID to MessageReactionAdd #798

Merged
merged 1 commit into from Apr 7, 2022

Conversation

ceriath
Copy link
Contributor

@ceriath ceriath commented Aug 5, 2020

Since i ran into the same issue today, the documentation for MessageReactionAdd should be improved, thanks to #750

@CarsonHoffman
Copy link
Collaborator

I definitely think that the documentation could be improved here, and though an example is surely helpful, I think actually defining the format would be helpful as well—it might not be immediately clear that hello:1234567654321 refers to name:id.

@adityaxdiwakar
Copy link
Contributor

I might be wrong here but doesn't the format also require a colon, such as :name:id?
image

@CarsonHoffman
Copy link
Collaborator

The leading colon is necessary when specifying an emoji in the content of a message; it is not necessary when specifying an emoji in an API context. (I believe it won't fail as it will be considered part of the name, as the API seems to parse name:id from right-to-left starting from the ID and considering everything before the right-most colon as part of the name)

@FedorLap2006 FedorLap2006 changed the title Improve docs Add example of emojiID to MessageReactionAdd Mar 29, 2022
restapi.go Outdated Show resolved Hide resolved
@FedorLap2006
Copy link
Collaborator

Sorry response took a long time.

improve documentation for MessageReactionAdd according to bwmarrin#750
@ceriath
Copy link
Contributor Author

ceriath commented Apr 7, 2022

I added the suggestion

@FedorLap2006
Copy link
Collaborator

Thanks for your contribution!

@FedorLap2006 FedorLap2006 merged commit fb0692b into bwmarrin:master Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants