Slash commands example: parse options into a map #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If options can be recursive, we can implement that to the existing loop while unmarshalling. Otherwise, this should be good to go! |
|
If the subcommand example is correct, there can be parsed recursive options. However, they can't have the same name as other options. I will implement a recursive parse and example tomorrow. |
FedorLap2006
changed the title
|
|
FedorLap2006
requested changes
Mar 22, 2022
There was a problem hiding this comment.
As I said in the original issue, DiscordGo is 1:1 mapping of Discord API. I don't think that adding an extra option, which would be just a reflection of the original, is a good idea.
That said, I think it would fair to still showcase parsing options into a map in the example.
Additionally, note my comments.
removes parseMap from the API and requires user inclusion
FedorLap2006
changed the title
FedorLap2006
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1126 Method 3
The resulting example output:
